Skip to content

bench: update random value generation #9820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kgryte merged 2 commits into from
Jan 26, 2026
Merged

bench: update random value generation #9820

kgryte merged 2 commits into from
Jan 26, 2026

Conversation

@hrshya
Copy link
Contributor

@hrshya hrshya commented Jan 18, 2026

Resolves none .

Description

What is the purpose of this pull request?

This pull request:

  • Refactors random number generation in JS benchmarks for the stats/base/dists/planck/* packages.
  • Replaces uniform() from @stdlib/random/array/uniform for cleaner and more consistent code.
  • Moves the random number generation outside the benchmarking loops.
  • Updates the test messages to follow code conventions.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves no related issues.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 18, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 18, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/planck/cdf $\color{green}279/279$
$\color{green}+0.00%$ 		$\color{green}25/25$
$\color{green}+0.00%$ 		$\color{green}4/4$
$\color{green}+0.00%$ 		$\color{green}279/279$
$\color{green}+0.00%$
stats/base/dists/planck/entropy $\color{green}170/170$
$\color{green}+0.00%$ 		$\color{green}8/8$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}170/170$
$\color{green}+0.00%$
stats/base/dists/planck/kurtosis $\color{green}162/162$
$\color{green}+0.00%$ 		$\color{green}8/8$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}162/162$
$\color{green}+0.00%$
stats/base/dists/planck/logcdf $\color{green}283/283$
$\color{green}+0.00%$ 		$\color{green}25/25$
$\color{green}+0.00%$ 		$\color{green}4/4$
$\color{green}+0.00%$ 		$\color{green}283/283$
$\color{green}+0.00%$
stats/base/dists/planck/logpmf $\color{green}278/278$
$\color{green}+0.00%$ 		$\color{green}21/21$
$\color{green}+0.00%$ 		$\color{green}4/4$
$\color{green}+0.00%$ 		$\color{green}278/278$
$\color{green}+0.00%$
stats/base/dists/planck/mean $\color{green}170/170$
$\color{green}+0.00%$ 		$\color{green}8/8$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}170/170$
$\color{green}+0.00%$
stats/base/dists/planck/median $\color{green}163/163$
$\color{green}+0.00%$ 		$\color{green}8/8$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}163/163$
$\color{green}+0.00%$
stats/base/dists/planck/mgf $\color{green}252/252$
$\color{green}+0.00%$ 		$\color{green}17/17$
$\color{green}+0.00%$ 		$\color{green}4/4$
$\color{green}+0.00%$ 		$\color{green}252/252$
$\color{green}+0.00%$
stats/base/dists/planck/mode $\color{green}161/161$
$\color{green}+0.00%$ 		$\color{green}8/8$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}161/161$
$\color{green}+0.00%$
stats/base/dists/planck/pmf $\color{green}276/276$
$\color{green}+0.00%$ 		$\color{green}21/21$
$\color{green}+0.00%$ 		$\color{green}4/4$
$\color{green}+0.00%$ 		$\color{green}276/276$
$\color{green}+0.00%$
stats/base/dists/planck/quantile $\color{green}286/286$
$\color{green}+0.00%$ 		$\color{green}25/25$
$\color{green}+0.00%$ 		$\color{green}4/4$
$\color{green}+0.00%$ 		$\color{green}286/286$
$\color{green}+0.00%$
stats/base/dists/planck/skewness $\color{green}162/162$
$\color{green}+0.00%$ 		$\color{green}8/8$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}162/162$
$\color{green}+0.00%$
stats/base/dists/planck/stdev $\color{green}166/166$
$\color{green}+0.00%$ 		$\color{green}8/8$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}166/166$
$\color{green}+0.00%$
stats/base/dists/planck/variance $\color{green}165/165$
$\color{green}+0.00%$ 		$\color{green}8/8$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}165/165$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added Benchmarks Pull requests adding or improving benchmarks for measuring performance. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. labels Jan 25, 2026
kgryte
kgryte approved these changes Jan 26, 2026
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jan 26, 2026
@kgryte kgryte merged commit c404057 into stdlib-js:develop Jan 26, 2026
47 checks passed
@hrshya hrshya deleted the bench/planck branch January 26, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

+1 more reviewer

@SuYaSh-PaThAk04 SuYaSh-PaThAk04 SuYaSh-PaThAk04 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hrshya @stdlib-bot @kgryte @SuYaSh-PaThAk04